-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Button): Add support for two icon buttons #1643
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelDill
force-pushed
the
f/two-icon-button
branch
from
December 19, 2024 20:10
8043d51
to
e6135fa
Compare
MichaelDill
changed the title
Add support for two icon buttons
feat(Button): Add support for two icon buttons
Dec 19, 2024
Visit the preview URL for this PR (updated for commit 5a7c0fa): https://novo-elements--pr1643-f-two-icon-button-6ew7eh9e.web.app (expires Thu, 16 Jan 2025 20:53:23 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f1783e19c2444272095017dd8ba433fff0ee3f61 |
ndickerson
reviewed
Jan 7, 2025
ndickerson
previously approved these changes
Jan 7, 2025
dvoegelin
reviewed
Jan 7, 2025
ndickerson
previously approved these changes
Jan 7, 2025
dvoegelin
approved these changes
Jan 13, 2025
ndickerson
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
INSERT A SMALL DESCRIPTION OF WHAT YOU CHANGED HERE
Verify that...
npm start
andnpm run build
still worksSafari
,Chrome
andFirefox
npm run lint
passesnpm test
passes and code coverage is increasednpm run build
still worksBullhorn Internal Developers
Novo Automation
Screenshots