-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(external-dns): use latest and greatest --gateway-name #3547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--- kubernetes/apps/networking/external-dns/unifi Kustomization: networking/external-dns-unifi HelmRelease: networking/external-dns-unifi
+++ kubernetes/apps/networking/external-dns/unifi Kustomization: networking/external-dns-unifi HelmRelease: networking/external-dns-unifi
@@ -31,13 +31,13 @@
values:
domainFilters:
- ktwo.io
fullnameOverride: external-dns-unifi
image:
repository: ghcr.io/buroa/external-dns
- tag: 631b84da
+ tag: 47731b39
podAnnotations:
secret.reloader.stakater.com/reload: external-dns-unifi-secret
policy: sync
provider:
name: webhook
webhook:
--- kubernetes/apps/networking/external-dns/cloudflare Kustomization: networking/external-dns-cloudflare HelmRelease: networking/external-dns-cloudflare
+++ kubernetes/apps/networking/external-dns/cloudflare Kustomization: networking/external-dns-cloudflare HelmRelease: networking/external-dns-cloudflare
@@ -42,18 +42,18 @@
secretKeyRef:
key: CF_ZONE_ID
name: external-dns-cloudflare-secret
extraArgs:
- --cloudflare-dns-records-per-page=1000
- --cloudflare-proxied
- - --gateway-label-filter=gateway==external
+ - --gateway-name=external
- --zone-id-filter=$(CF_ZONE_ID)
fullnameOverride: external-dns-cloudflare
image:
repository: ghcr.io/buroa/external-dns
- tag: 631b84da
+ tag: 47731b39
podAnnotations:
secret.reloader.stakater.com/reload: external-dns-cloudflare-secret
policy: sync
provider: cloudflare
serviceMonitor:
enabled: true
--- kubernetes/apps/kube-system/cilium/gateway Kustomization: kube-system/cilium-gateway Gateway: kube-system/external
+++ kubernetes/apps/kube-system/cilium/gateway Kustomization: kube-system/cilium-gateway Gateway: kube-system/external
@@ -3,13 +3,12 @@
kind: Gateway
metadata:
annotations:
external-dns.alpha.kubernetes.io/target: external.ktwo.io
labels:
app.kubernetes.io/name: cilium-gateway
- gateway: external
kustomize.toolkit.fluxcd.io/name: cilium-gateway
kustomize.toolkit.fluxcd.io/namespace: kube-system
name: external
namespace: kube-system
spec:
addresses:
--- kubernetes/apps/kube-system/cilium/gateway Kustomization: kube-system/cilium-gateway Gateway: kube-system/internal
+++ kubernetes/apps/kube-system/cilium/gateway Kustomization: kube-system/cilium-gateway Gateway: kube-system/internal
@@ -3,13 +3,12 @@
kind: Gateway
metadata:
annotations:
external-dns.alpha.kubernetes.io/target: internal.ktwo.io
labels:
app.kubernetes.io/name: cilium-gateway
- gateway: internal
kustomize.toolkit.fluxcd.io/name: cilium-gateway
kustomize.toolkit.fluxcd.io/namespace: kube-system
name: internal
namespace: kube-system
spec:
addresses: |
--- HelmRelease: networking/external-dns-unifi Deployment: networking/external-dns-unifi
+++ HelmRelease: networking/external-dns-unifi Deployment: networking/external-dns-unifi
@@ -39,13 +39,13 @@
- ALL
privileged: false
readOnlyRootFilesystem: true
runAsGroup: 65532
runAsNonRoot: true
runAsUser: 65532
- image: ghcr.io/buroa/external-dns:631b84da
+ image: ghcr.io/buroa/external-dns:47731b39
imagePullPolicy: IfNotPresent
args:
- --log-level=info
- --log-format=text
- --interval=1m
- --events
--- HelmRelease: networking/external-dns-cloudflare Deployment: networking/external-dns-cloudflare
+++ HelmRelease: networking/external-dns-cloudflare Deployment: networking/external-dns-cloudflare
@@ -39,13 +39,13 @@
- ALL
privileged: false
readOnlyRootFilesystem: true
runAsGroup: 65532
runAsNonRoot: true
runAsUser: 65532
- image: ghcr.io/buroa/external-dns:631b84da
+ image: ghcr.io/buroa/external-dns:47731b39
imagePullPolicy: IfNotPresent
env:
- name: CF_API_TOKEN
valueFrom:
secretKeyRef:
key: CF_API_TOKEN
@@ -66,13 +66,13 @@
- --txt-owner-id=k8s
- --txt-prefix=k8s.
- --domain-filter=ktwo.io
- --provider=cloudflare
- --cloudflare-dns-records-per-page=1000
- --cloudflare-proxied
- - --gateway-label-filter=gateway==external
+ - --gateway-name=external
- --zone-id-filter=$(CF_ZONE_ID)
ports:
- name: http
protocol: TCP
containerPort: 7979
livenessProbe: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.