feat(external-dns): jank post renders #3553
Merged
+25
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--- HelmRelease: networking/external-dns-cloudflare Deployment: networking/external-dns-cloudflare
+++ HelmRelease: networking/external-dns-cloudflare Deployment: networking/external-dns-cloudflare
@@ -19,13 +19,13 @@
template:
metadata:
labels:
app.kubernetes.io/name: external-dns
app.kubernetes.io/instance: external-dns-cloudflare
annotations:
- secret.reloader.stakater.com/reload: external-dns-cloudflare-secret
+ reloader.stakater.com/auto: 'true'
spec:
serviceAccountName: external-dns-cloudflare
securityContext:
fsGroup: 65534
runAsNonRoot: true
seccompProfile:
@@ -41,23 +41,12 @@
readOnlyRootFilesystem: true
runAsGroup: 65532
runAsNonRoot: true
runAsUser: 65532
image: ghcr.io/buroa/external-dns:a6243325
imagePullPolicy: IfNotPresent
- env:
- - name: CF_API_TOKEN
- valueFrom:
- secretKeyRef:
- key: CF_API_TOKEN
- name: external-dns-cloudflare-secret
- - name: CF_ZONE_ID
- valueFrom:
- secretKeyRef:
- key: CF_ZONE_ID
- name: external-dns-cloudflare-secret
args:
- --log-level=info
- --log-format=text
- --interval=1m
- --events
- --source=gateway-httproute
--- HelmRelease: networking/external-dns-unifi Deployment: networking/external-dns-unifi
+++ HelmRelease: networking/external-dns-unifi Deployment: networking/external-dns-unifi
@@ -19,13 +19,13 @@
template:
metadata:
labels:
app.kubernetes.io/name: external-dns
app.kubernetes.io/instance: external-dns-unifi
annotations:
- secret.reloader.stakater.com/reload: external-dns-unifi-secret
+ reloader.stakater.com/auto: 'true'
spec:
serviceAccountName: external-dns-unifi
securityContext:
fsGroup: 65534
runAsNonRoot: true
seccompProfile:
@@ -82,17 +82,12 @@
- name: webhook
image: ghcr.io/kashalls/external-dns-unifi-webhook:v0.4.3@sha256:1a58193c2c1985f4ce5ef4031be38d740daa4b1c54b0edbd2299524504e8d60e
imagePullPolicy: IfNotPresent
env:
- name: UNIFI_HOST
value: https://unifi.internal
- - name: UNIFI_API_KEY
- valueFrom:
- secretKeyRef:
- key: UNIFI_API_KEY
- name: external-dns-unifi-secret
ports:
- name: http-webhook
protocol: TCP
containerPort: 8080
livenessProbe:
failureThreshold: 2 |
--- kubernetes/apps/networking/external-dns/cloudflare Kustomization: networking/external-dns-cloudflare HelmRelease: networking/external-dns-cloudflare
+++ kubernetes/apps/networking/external-dns/cloudflare Kustomization: networking/external-dns-cloudflare HelmRelease: networking/external-dns-cloudflare
@@ -19,43 +19,43 @@
version: 1.15.2
install:
crds: CreateReplace
remediation:
retries: 3
interval: 1h
+ postRenderers:
+ - kustomize:
+ patches:
+ - patch: |
+ - op: add
+ path: /spec/template/spec/containers/0/envFrom/-
+ value:
+ secretRef:
+ name: external-dns-cloudflare-secret
+ target:
+ kind: Deployment
upgrade:
cleanupOnFail: true
crds: CreateReplace
remediation:
retries: 3
strategy: rollback
values:
domainFilters:
- ktwo.io
- env:
- - name: CF_API_TOKEN
- valueFrom:
- secretKeyRef:
- key: CF_API_TOKEN
- name: external-dns-cloudflare-secret
- - name: CF_ZONE_ID
- valueFrom:
- secretKeyRef:
- key: CF_ZONE_ID
- name: external-dns-cloudflare-secret
extraArgs:
- --cloudflare-dns-records-per-page=1000
- --cloudflare-proxied
- --gateway-name=external
- --zone-id-filter=$(CF_ZONE_ID)
fullnameOverride: external-dns-cloudflare
image:
repository: ghcr.io/buroa/external-dns
tag: a6243325
podAnnotations:
- secret.reloader.stakater.com/reload: external-dns-cloudflare-secret
+ reloader.stakater.com/auto: 'true'
policy: sync
provider: cloudflare
serviceMonitor:
enabled: true
sources:
- gateway-httproute
--- kubernetes/apps/networking/external-dns/unifi Kustomization: networking/external-dns-unifi HelmRelease: networking/external-dns-unifi
+++ kubernetes/apps/networking/external-dns/unifi Kustomization: networking/external-dns-unifi HelmRelease: networking/external-dns-unifi
@@ -19,12 +19,24 @@
version: 1.15.2
install:
crds: CreateReplace
remediation:
retries: 3
interval: 1h
+ postRenderers:
+ - kustomize:
+ patches:
+ - patch: |
+ - op: add
+ path: /spec/template/spec/containers/1/envFrom/-
+ value:
+ secretRef:
+ name: external-dns-unifi-secret
+ target:
+ kind: Deployment
+ name: null
upgrade:
cleanupOnFail: true
crds: CreateReplace
remediation:
retries: 3
strategy: rollback
@@ -33,25 +45,20 @@
- ktwo.io
fullnameOverride: external-dns-unifi
image:
repository: ghcr.io/buroa/external-dns
tag: a6243325
podAnnotations:
- secret.reloader.stakater.com/reload: external-dns-unifi-secret
+ reloader.stakater.com/auto: 'true'
policy: sync
provider:
name: webhook
webhook:
env:
- name: UNIFI_HOST
value: https://unifi.internal
- - name: UNIFI_API_KEY
- valueFrom:
- secretKeyRef:
- key: UNIFI_API_KEY
- name: external-dns-unifi-secret
image:
repository: ghcr.io/kashalls/external-dns-unifi-webhook
tag: v0.4.3@sha256:1a58193c2c1985f4ce5ef4031be38d740daa4b1c54b0edbd2299524504e8d60e
livenessProbe:
httpGet:
path: /healthz |
buroa
added a commit
that referenced
this pull request
Mar 12, 2025
buroa
added a commit
that referenced
this pull request
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.