Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement BuildRun and CompileRun configurations #8

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

yui019
Copy link
Contributor

@yui019 yui019 commented Jan 3, 2025

Hello!
I finished implementing the functionality of the "C3 Single File" and "C3 Run Project" configurations you'd started before.

I added the options to set the working directory and additional arguments in both the configurations.

Also, I'm not sure if there was a reason for it, but the sdk field in C3SettingsState was set to an empty string before, so the commands couldn't run. I set it to "c3c" instead. I assume this is supposed to be a modifiable value so that's why it's in the settings? Anyway "c3c" is probably a reasonable default so I just kept that change.

Anyway, try it out and let me know what you think! I think it should be fine...

@lerno
Copy link
Contributor

lerno commented Jan 3, 2025

This worked fine for me!

@lerno lerno merged commit 7bad984 into c3lang:master Jan 3, 2025
1 check failed
@lerno
Copy link
Contributor

lerno commented Jan 3, 2025

I've updated the plugin now to 0.0.20 and submitted it, should be available soon!

@lerno
Copy link
Contributor

lerno commented Jan 3, 2025

I found a warning that the following is deprecated:

TextFieldWithBrowseButton.addBrowseFolderListener(...) is invoked in C3BuildRunEditor.createUIComponents().

So that one should be changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants