-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mod_ssl-like Placeholder Support for Server and Client Certificates in Caddy #6780
base: master
Are you sure you want to change the base?
Conversation
…luding mod_ssl-like behavior
|
…lient certificates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the lowercase placeholder and comments on the change.
@mohammed90 just checking in too see if everything for the PR looks good ? |
At first glance, it looks fine, but I haven't had the time to review it thoroughly. We'll get to it. |
This pull request introduces functionality similar to Apache's mod_ssl by adding support for dynamic placeholders for server and client certificates in Caddy. The implementation addresses the following:
1)Dynamic Placeholder Population:
Populates placeholders for both server and client certificates during TLS connections, enabling detailed certificate information to be accessed in configurations (e.g., headers, logs).
2)Support for Default Values:
Ensures placeholders return meaningful default values (e.g., null or descriptive strings) when client certificates are not provided (e.g., in non-mTLS scenarios).
3)Centralized Logic:
Introduced a new function, handleMTLSEnabledWithExport, to handle placeholder population efficiently, reducing redundancy and improving maintainability.