Add initial ActivityExecutor #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timl3136
reviewed
Aug 29, 2025
| @@ -29,7 +29,7 @@ async def poll(_, timeout=0.0): | |||
| type(client).domain = PropertyMock(return_value="domain") | |||
| type(client).identity = PropertyMock(return_value="identity") | |||
|
|
|||
| worker = Worker(client, "task_list", activity_task_pollers=1, decision_task_pollers=1, identity="identity") | |||
| worker = Worker(client, "task_list", Registry(), activity_task_pollers=1, decision_task_pollers=1, identity="identity") | |||
There was a problem hiding this comment.
nit: should we do some assertion on the field?
Create a basic activity executor capable of running functions as activities. Async functions are run as part of the main event loop, while sync ones are run in a threaadpool executor. Type hints are expected for any parameters the activity takes, with non-typed parameters receiving the deserialized json value as a standard python type (dict, list, string, etc.). Plenty of work remains for full activity support, such as maintaining an activity context for heartbeating.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a basic activity executor capable of running functions as activities. Async functions are run as part of the main event loop, while sync ones are run in a threaadpool executor.
Type hints are expected for any parameters the activity takes, with non-typed parameters receiving the deserialized json value as a standard python type (dict, list, string, etc.).
Plenty of work remains for full activity support, such as maintaining an activity context for heartbeating.
What changed?
Why?
How did you test it?
Potential risks
Release notes
Documentation Changes