Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor comments #22

Merged
merged 10 commits into from
Mar 10, 2025
Merged

Refactor comments #22

merged 10 commits into from
Mar 10, 2025

Conversation

legoeruro
Copy link
Contributor

Thank you Yiqin.

FelixNgFender and others added 10 commits January 16, 2025 22:17
@FelixNgFender
fix(client): race condition when clearing buffer after sending frames
73d1497
@FelixNgFender
feat(server): widen typings in public API for easier usage
8c931c2
@FelixNgFender
test(server): tests for new API
1530ff5 
Incomplete, still need fixing for image YUV420 conversion, add back in
test for that and missing test for point cloud detection in
`test_service.py` and `test_server.py`. All of these have been marked
with TODO marks.
@legoeruro
chore: Move transform into seperate entity path (origin pairing is do…
a85765b 
…ne on client), and add cmt for byte pad
@FelixNgFender
chore(server): benchmarks scaffolding
7337432
@FelixNgFender
fix(client): properly fallback to system clock if no NTP server speci…
d61bb7f 
…fied
@FelixNgFender
style(client): formatting
c09c1ac
@FelixNgFender
perf(client): sending AR frames directly consumes the iterator instea…
b53f298 
…d of copying
@legoeruro
chore(wip): evaluations for spacial/coordinates syncronization
a40397b
@legoeruro
New file for PR Comment (on Github)
464322f
@YiqinZhao YiqinZhao self-requested a review March 10, 2025 14:24
@YiqinZhao YiqinZhao marked this pull request as ready for review March 10, 2025 14:24
YiqinZhao
YiqinZhao approved these changes Mar 10, 2025
View reviewed changes
Copy link
Member

@YiqinZhao YiqinZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged for future development

@YiqinZhao YiqinZhao merged commit 89581af into cake-lab:main Mar 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YiqinZhao YiqinZhao YiqinZhao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@legoeruro @YiqinZhao @FelixNgFender