feat: Add step in team creation form for selecting event type and create a team event #15286

anikdhabal · 2024-05-31T22:21:07Z

What does this PR do?

Fixes [CAL-2960] default event-types after creating a team #13300

Result:-

Mandatory Tasks (DO NOT REMOVE)

I have self-reviewed the code (A decent size PR without self-review might be rejected)
N/A - I have added a Docs issue here if this PR makes changes that would require a documentation change
I have added or modified automated tests that prove my fix is effective or that my feature works (PRs might be rejected if logical changes are not properly tested)

vercel · 2024-05-31T22:21:13Z

@anikdhabal is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

github-actions · 2024-05-31T22:21:19Z

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

graphite-app · 2024-05-31T22:25:11Z

Graphite Automations

"Add community label" took an action on this PR • (05/31/24)

1 label was added to this PR based on Keith Williams's automation.

"Add consumer team as reviewer" took an action on this PR • (05/31/24)

1 reviewer was added to this PR based on Keith Williams's automation.

packages/features/ee/teams/components/TeamEventTypeForm.tsx

SomayChauhan

https://www.loom.com/share/2e468d97ba6a44c8a23f0eff0df02cf2?sid=e5d25316-5c68-47d1-918b-1604af8d458b

@anikdhabal could you add fix this
otherwise looks good 💯

anikdhabal · 2024-06-10T21:36:20Z

https://www.loom.com/share/2e468d97ba6a44c8a23f0eff0df02cf2?sid=e5d25316-5c68-47d1-918b-1604af8d458b

@anikdhabal could you add fix this otherwise looks good 💯

Thanks for the review. I've fixed that.

SomayChauhan

Tested, LGTM!!
Thankyou @anikdhabal, Great Work

CarinaWolli

some e2e tests are failing because of the new step when creating a team

anikdhabal · 2024-06-11T18:25:40Z

some e2e tests are failing because of the new step when creating a team

Yeah, I am on it.

github-actions · 2024-08-16T07:26:49Z

E2E results are ready!

Workflow #30540.1 latest results

packages/features/ee/teams/components/TeamEventTypeForm.tsx

packages/lib/hooks/useCreateEventType.ts

CarinaWolli

I think we should allow the user to skip the form, as they might not yet know which event type they need.

I am also wondering if it would also make sense to already assign team members. It might be too much, but then the event type would be functional (cc @ciaranha)

all requested changes were addressed

CarinaWolli

Nice work, the changes look good to me and looks like all other feedback has been addressed 🙏

feat: Create team event on a new team creation

1dbe941

graphite-app bot added the community label May 31, 2024

graphite-app bot requested a review from a team May 31, 2024 22:21

github-actions bot added consumer event-types Medium priority ✨ feature 🧹 Improvements labels May 31, 2024

dosubot bot added the teams label May 31, 2024

dosubot bot added this to the v4.2 milestone May 31, 2024

anikdhabal changed the title ~~feat: Create team event on a new team creation~~ feat: Add step in team creation form for selecting event type and create a team event May 31, 2024

SomayChauhan added 2 commits June 5, 2024 19:34

Merge branch 'main' into issue#13300

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

GPG key ID: B5690EEEBB952194

Verified
Learn about vigilant mode

0d1d120

Merge branch 'main' into issue#13300

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

GPG key ID: B5690EEEBB952194

Verified
Learn about vigilant mode

2236dc7

SomayChauhan reviewed Jun 9, 2024

View reviewed changes

packages/features/ee/teams/components/TeamEventTypeForm.tsx Outdated Show resolved Hide resolved

SomayChauhan requested changes Jun 9, 2024

View reviewed changes

fix

b9af6c1

Merge branch 'main' into issue#13300

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

GPG key ID: B5690EEEBB952194

Verified
Learn about vigilant mode

afd5899

SomayChauhan previously approved these changes Jun 11, 2024

View reviewed changes

keithwillcode added this pull request to the merge queue Jun 11, 2024

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 11, 2024

keithwillcode added this pull request to the merge queue Jun 11, 2024

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 11, 2024

CarinaWolli requested changes Jun 11, 2024

View reviewed changes

fixed failed tests

b4df867

anikdhabal dismissed SomayChauhan’s stale review via b4df867 June 12, 2024 16:03

Merge branch 'main' into issue#13300

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

GPG key ID: B5690EEEBB952194

Verified
Learn about vigilant mode

98df185

anikdhabal marked this pull request as ready for review August 16, 2024 07:27

Udit-takkar reviewed Aug 16, 2024

View reviewed changes

packages/features/ee/teams/components/TeamEventTypeForm.tsx Outdated Show resolved Hide resolved

Udit-takkar reviewed Aug 16, 2024

View reviewed changes

packages/lib/hooks/useCreateEventType.ts Outdated Show resolved Hide resolved

Update useCreateEventType.ts

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

GPG key ID: B5690EEEBB952194

Verified
Learn about vigilant mode

12958b1

dosubot bot removed this from the v4.4 milestone Aug 19, 2024

keithwillcode modified the milestones: v4.4, v4.5 Aug 19, 2024

CarinaWolli reviewed Aug 20, 2024

View reviewed changes

anikdhabal and others added 5 commits August 29, 2024 16:26

Merge branch 'main' into issue#13300

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

GPG key ID: B5690EEEBB952194

Verified
Learn about vigilant mode

74ee6e8

Merge branch 'main' into issue#13300

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

GPG key ID: B5690EEEBB952194

Verified
Learn about vigilant mode

76a9cb8

update

8788f24

Merge branch 'main' into issue#13300

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

GPG key ID: B5690EEEBB952194

Verified
Learn about vigilant mode

4c4f964

fix type error

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

GPG key ID: B5690EEEBB952194

Verified
Learn about vigilant mode

bf6eb3b

anikdhabal requested a review from Udit-takkar August 30, 2024 09:12

Udit-takkar and others added 5 commits August 31, 2024 12:22

Merge branch 'main' into issue#13300

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

GPG key ID: B5690EEEBB952194

Verified
Learn about vigilant mode

ab97a29

fix e2e

8dd591b

Merge branch 'main' into issue#13300

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

GPG key ID: B5690EEEBB952194

Verified
Learn about vigilant mode

b0215a0

update

014ccff

Merge branch 'main' into issue#13300

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

GPG key ID: B5690EEEBB952194

Verified
Learn about vigilant mode

a4944ac

CarinaWolli approved these changes Sep 5, 2024

View reviewed changes

CarinaWolli merged commit fced9a6 into calcom:main Sep 5, 2024
32 of 39 checks passed

dosubot bot modified the milestones: v4.5, v4.6 Sep 15, 2024

keithwillcode modified the milestones: v4.6, v4.5 Sep 15, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add step in team creation form for selecting event type and create a team event #15286

feat: Add step in team creation form for selecting event type and create a team event #15286

anikdhabal commented May 31, 2024 •

edited by keithwillcode

Loading

vercel bot commented May 31, 2024

github-actions bot commented May 31, 2024 •

edited

Loading

graphite-app bot commented May 31, 2024

SomayChauhan left a comment

anikdhabal commented Jun 10, 2024

SomayChauhan left a comment •

edited

Loading

CarinaWolli left a comment

anikdhabal commented Jun 11, 2024

github-actions bot commented Aug 16, 2024 •

edited

Loading

CarinaWolli left a comment

CarinaWolli left a comment

feat: Add step in team creation form for selecting event type and create a team event #15286

feat: Add step in team creation form for selecting event type and create a team event #15286

Conversation

anikdhabal commented May 31, 2024 • edited by keithwillcode Loading

What does this PR do?

Mandatory Tasks (DO NOT REMOVE)

vercel bot commented May 31, 2024

github-actions bot commented May 31, 2024 • edited Loading

graphite-app bot commented May 31, 2024

Graphite Automations

SomayChauhan left a comment

Choose a reason for hiding this comment

anikdhabal commented Jun 10, 2024

SomayChauhan left a comment • edited Loading

Choose a reason for hiding this comment

CarinaWolli left a comment

Choose a reason for hiding this comment

anikdhabal commented Jun 11, 2024

github-actions bot commented Aug 16, 2024 • edited Loading

E2E results are ready!

CarinaWolli left a comment

Choose a reason for hiding this comment

CarinaWolli left a comment

Choose a reason for hiding this comment

anikdhabal commented May 31, 2024 •

edited by keithwillcode

Loading

github-actions bot commented May 31, 2024 •

edited

Loading

SomayChauhan left a comment •

edited

Loading

github-actions bot commented Aug 16, 2024 •

edited

Loading