Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Time zone update not syncing with all events #18627

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: Time zone update not syncing with all events #18627

wants to merge 4 commits into from
+1 −1

Conversation

KrishanGoyal1
Copy link

@KrishanGoyal1 KrishanGoyal1 commented Jan 13, 2025 •
edited
Loading

What does this PR do?

Description

Updated schedule on user id which was just updating schedule with defaultScheduleId only.

image

https://www.loom.com/share/aa892fbdbd5e41529a986e45d6407d1b

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

@vercel Vercel
Copy link

vercel bot commented Jan 13, 2025

@KrishanGoyal1 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Jan 13, 2025
@graphite-app graphite-app bot requested a review from a team January 13, 2025 12:42
@github-actions github-actions bot added bookings area: bookings, availability, timezones, double booking 🐛 bug Something isn't working labels Jan 13, 2025
@graphite-app Graphite App
Copy link

graphite-app bot commented Jan 13, 2025 •
edited
Loading

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (01/13/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (01/13/25)

1 label was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (01/14/25)

1 label was added to this PR based on Keith Williams's automation.

Praashh
Praashh requested changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@Praashh Praashh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you attach a loom video for the fix ?

@KrishanGoyal1
Copy link
Author

can you attach a loom video for the fix ?
Added:
https://www.loom.com/share/aa892fbdbd5e41529a986e45d6407d1b

@KrishanGoyal1 KrishanGoyal1 requested a review from Praashh January 14, 2025 07:27
Praashh
Praashh approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@Praashh Praashh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

Praashh
Praashh requested changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@Praashh Praashh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linting checks are failing, can you please fix?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 14, 2025 •
edited
Loading

E2E results are ready!

@KrishanGoyal1
Copy link
Author

Linting checks are failing, can you please fix?

Hi @Praashh
Lint errors could have been because of not updating the latest branch.
Fixed it and all checks are successful now 😄

@KrishanGoyal1 KrishanGoyal1 requested a review from Praashh January 14, 2025 18:16
Praashh
Praashh approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@Praashh Praashh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Praashh Praashh Praashh approved these changes

Assignees
No one assigned
Labels
bookings area: bookings, availability, timezones, double booking 🐛 bug Something isn't working community Created by Linear-GitHub Sync ready-for-e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Time zone update not syncing with all events
2 participants
@KrishanGoyal1 @Praashh