Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: synchronize no show state in booking listing item between edit & display #18648

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

cnhhoang850
Copy link
Contributor

@cnhhoang850 cnhhoang850 commented Jan 14, 2025

What does this PR do?

  • Old component managed states & mutation in each child component, making them unsynchronized
  • Lift attendees state from children component to parent BookingListItem component
  • Lift managing no show from children component to parent BookingListItem component

Before

Screen.Recording.2025-01-16.at.10.55.35.mov

After

Screen.Recording.2025-01-16.at.10.56.27.mov

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Go to bookings
  • Set no shows

Copy link

vercel bot commented Jan 14, 2025

@cnhhoang850 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Jan 14, 2025
@graphite-app graphite-app bot requested a review from a team January 14, 2025 10:07
@dosubot dosubot bot added bookings area: bookings, availability, timezones, double booking 🐛 bug Something isn't working labels Jan 14, 2025
Copy link

graphite-app bot commented Jan 14, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (01/14/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (01/14/25)

1 label was added to this PR based on Keith Williams's automation.

@cnhhoang850 cnhhoang850 changed the title fix: lift booking no show state fix: synchronize no show state in booking listing item between edit & display Jan 16, 2025
@cnhhoang850
Copy link
Contributor Author

@Praashh could you give this one a look? Thank you

Copy link
Contributor

@Praashh Praashh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but will do a final touch..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bookings area: bookings, availability, timezones, double booking 🐛 bug Something isn't working community Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants