Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no show status conflict #18667

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

MehulZR
Copy link
Contributor

@MehulZR MehulZR commented Jan 15, 2025

What does this PR do?

Before:

Before.mp4

After:

After.mp4

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

Copy link

vercel bot commented Jan 15, 2025

@MehulZR is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Jan 15, 2025
@graphite-app graphite-app bot requested a review from a team January 15, 2025 01:05
@github-actions github-actions bot added bookings area: bookings, availability, timezones, double booking Medium priority Created by Linear-GitHub Sync 🐛 bug Something isn't working labels Jan 15, 2025
@dosubot dosubot bot added this to the v4.9 milestone Jan 15, 2025
Copy link

graphite-app bot commented Jan 15, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (01/15/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (01/15/25)

1 label was added to this PR based on Keith Williams's automation.

Copy link
Contributor

@Praashh Praashh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we already have a PR for this issue, you can check this #17659 (review)

@MehulZR
Copy link
Contributor Author

MehulZR commented Jan 15, 2025

Hey @Praashh, In #17659 the implementation is different and the author seems unresponsive for now to make the desired changes requested by Udit.

Copy link
Contributor

@Praashh Praashh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please fix merge conflicts?

@MehulZR
Copy link
Contributor Author

MehulZR commented Jan 15, 2025

Working on it.

@MehulZR
Copy link
Contributor Author

MehulZR commented Jan 15, 2025

no.show.status.conflict.update.webm

As we have moved to tanstack table, we have to batch the mutations of attendees in the noShowAttendeesDialog.
Otherwise a single toggle mutation will reset(update the trpc client cache) the table. Resulting in noShowAttendeesDialog being closed preemptively.

@dosubot dosubot bot modified the milestones: v4.9, v4.10 Jan 16, 2025
Copy link
Contributor

@Praashh Praashh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but it still needs a final touch.

@dosubot dosubot bot modified the milestone: v4.10 Jan 16, 2025
@MehulZR
Copy link
Contributor Author

MehulZR commented Jan 16, 2025

@Praashh Final touch as in review or a nit?

@dosubot dosubot bot modified the milestone: v4.10 Jan 16, 2025
@Praashh
Copy link
Contributor

Praashh commented Jan 16, 2025

@Praashh Final touch as in review or a nit?

yes final review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bookings area: bookings, availability, timezones, double booking 🐛 bug Something isn't working community Created by Linear-GitHub Sync Medium priority Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-4715] No show status not updated
2 participants