chore: Update "@hubspot/api-client" from 6.0.1 to 12.0.1 CAL-[5029]
#18670
+88
−81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….oauth.tokensApi.create()`
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (01/15/25)1 reviewer was added to this PR based on Keith Williams's automation. "Add foundation team as reviewer" took an action on this PR • (01/15/25)1 reviewer was added to this PR based on Keith Williams's automation. |
dosubot
bot
added
crm-apps
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
joeauyeung
commented
Jan 15, 2025
| @@ -1,4 +1,4 @@ | |||
| import * as hubspot from "@hubspot/api-client"; | |||
There was a problem hiding this comment.
Let's import specifically what we need
| @@ -38,7 +39,7 @@ export default async function handler(req: NextApiRequest, res: NextApiResponse) | |||
| if (!client_id) return res.status(400).json({ message: "HubSpot client id missing." }); | |||
| if (!client_secret) return res.status(400).json({ message: "HubSpot client secret missing." }); | |||
|
|
|||
| const hubspotToken: HubspotToken = await hubspotClient.oauth.tokensApi.createToken( | |||
| const hubspotToken: HubspotToken = await oauth.tokensApi.create( | |||
There was a problem hiding this comment.
Change in method from .createToken() to create()
| hs_meeting_end_time: new Date(event.endTime).toISOString(), | ||
| hs_meeting_outcome: "SCHEDULED", | ||
| }, | ||
| associations: contacts.reduce((associations, contact) => { |
There was a problem hiding this comment.
Instead of making a separate call to associate a meeting with a contact, we can do it in one call. It'll actually throw a type error if we don't.
| @@ -227,7 +229,7 @@ export default class HubspotCalendarService implements CRM { | |||
| return contacts.map((contact) => { | |||
| return { | |||
| id: contact.id, | |||
| email: contact.properties.email, | |||
| email: contact.properties.email || "", | |||
There was a problem hiding this comment.
Emails are required for contacts so not sure why it's throwing a string | null type here.
joeauyeung
changed the title
6.0.1 to 12.0.16.0.1 to 12.0.1 CAL-[5029]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?