Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resize app-store images to use less bytes #18675

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: resize app-store images to use less bytes #18675

wants to merge 1 commit into from

Conversation

nizzyabi
Copy link
Contributor

@nizzyabi nizzyabi commented Jan 15, 2025 •
edited
Loading

What does this PR do?

I resized some app-store images to require less bytes as some were too big including ones for make, meta-pixel, ping, campsite, and zoom.

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

Check image sizes for app-store images that were changed
Go to app-store and look at images in make, meta-pixel, ping, campsite, and zoom to see if they are there

@graphite-app graphite-app bot requested a review from a team January 15, 2025 04:46
@keithwillcode keithwillcode added the core area: core, team members only label Jan 15, 2025
@dosubot dosubot bot added the app-store area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar label Jan 15, 2025
@graphite-app Graphite App
Copy link

graphite-app bot commented Jan 15, 2025 •
edited
Loading

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (01/15/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (01/15/25)

1 label was added to this PR based on Keith Williams's automation.

emrysal
emrysal approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool 👍

@github-actions GitHub Actions
Copy link
Contributor

E2E results are ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emrysal emrysal emrysal approved these changes

Assignees
No one assigned
Labels
app-store area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar core area: core, team members only ready-for-e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nizzyabi @emrysal @keithwillcode