Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: recording url with 6 months expiry time #18707

Open
wants to merge 4 commits into
base: feat/add-s3-bucket
Choose a base branch
from

Conversation

Udit-takkar
Copy link
Contributor

@Udit-takkar Udit-takkar commented Jan 16, 2025

What does this PR do?

Merge #17050 before this PR

  • Fixes #XXXX (GitHub issue number)
  • Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)
Screen.Recording.2025-01-16.at.2.35.55.PM.mov

This sends the api route url to emails and webhook which then fetches the actual download link from daily video if the token is valid

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

@graphite-app graphite-app bot requested a review from a team January 16, 2025 09:08
@github-actions github-actions bot added the ❗️ .env changes contains changes to env variables label Jan 16, 2025
Copy link
Contributor

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Feat/recording with no expiry". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@keithwillcode keithwillcode added core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO labels Jan 16, 2025
@dosubot dosubot bot added the ✨ feature New feature or request label Jan 16, 2025
Copy link

graphite-app bot commented Jan 16, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (01/16/25)

1 reviewer was added to this PR based on Keith Williams's automation.

@Udit-takkar Udit-takkar changed the title Feat/recording with no expiry feat: recording url with 6 months expiry time Jan 16, 2025
Copy link

vercel bot commented Jan 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Jan 16, 2025 9:33am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Jan 16, 2025 9:33am

@Udit-takkar Udit-takkar changed the base branch from main to feat/add-s3-bucket January 16, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO ❗️ .env changes contains changes to env variables ✨ feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants