-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: recording url with 6 months expiry time #18707
Open
Udit-takkar
wants to merge
4
commits into
feat/add-s3-bucket
Choose a base branch
from
feat/recording-with-no-expiry
base: feat/add-s3-bucket
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+153
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details:
|
keithwillcode
added
core
area: core, team members only
enterprise
area: enterprise, audit log, organisation, SAML, SSO
labels
Jan 16, 2025
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (01/16/25)1 reviewer was added to this PR based on Keith Williams's automation. |
Udit-takkar
changed the title
Feat/recording with no expiry
feat: recording url with 6 months expiry time
Jan 16, 2025
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
core
area: core, team members only
enterprise
area: enterprise, audit log, organisation, SAML, SSO
❗️ .env changes
contains changes to env variables
✨ feature
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Merge #17050 before this PR
Screen.Recording.2025-01-16.at.2.35.55.PM.mov
This sends the api route url to emails and webhook which then fetches the actual download link from daily video if the token is valid
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?