Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow non-calcom domains to run team slug pages #18711

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

emrysal
Copy link
Contributor

@emrysal emrysal commented Jan 16, 2025

What does this PR do?

  • Fixup repository anti pattern
  • Don't auto redirect when we're not on Cal.com pages. (good for vercel URLs e.g. where we don't have org subdomains)

@graphite-app graphite-app bot requested a review from a team January 16, 2025 11:43
Copy link
Contributor

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

Unknown release type "feature" found in pull request title "feature: Allow non-calcom domains to run team slug pages". 

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@keithwillcode keithwillcode added core area: core, team members only foundation labels Jan 16, 2025
Copy link

graphite-app bot commented Jan 16, 2025

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (01/16/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add platform team as reviewer" took an action on this PR • (01/16/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (01/16/25)

1 label was added to this PR based on Keith Williams's automation.

@dosubot dosubot bot added platform Anything related to our platform plan teams area: teams, round robin, collective, managed event-types ✨ feature New feature or request labels Jan 16, 2025
@graphite-app graphite-app bot requested a review from a team January 16, 2025 11:45
@emrysal emrysal changed the title feature: Allow non-calcom domains to run team slug pages feat: Allow non-calcom domains to run team slug pages Jan 16, 2025
Copy link
Contributor

E2E results are ready!

@keithwillcode keithwillcode merged commit b7f7c33 into main Jan 16, 2025
59 of 104 checks passed
@keithwillcode keithwillcode deleted the feature/dont-redirect-on-local-or-vercel-urls branch January 16, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core area: core, team members only ✨ feature New feature or request foundation platform Anything related to our platform plan ready-for-e2e teams area: teams, round robin, collective, managed event-types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants