Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: filters ui breaking on mobile in routing insights page #18713

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: filters ui breaking on mobile in routing insights page #18713

wants to merge 1 commit into from
+4 −5

Conversation

cnhhoang850
Copy link
Contributor

What does this PR do?

  • Fix ui breaking for filters in Datatable

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

Before

Screen.Recording.2025-01-16.at.20.03.56.mov

After

Screen.Recording.2025-01-16.at.19.59.42.mov

@vercel Vercel
Copy link

vercel bot commented Jan 16, 2025

@cnhhoang850 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Jan 16, 2025
@graphite-app graphite-app bot requested a review from a team January 16, 2025 13:22
@graphite-app Graphite App
Copy link

graphite-app bot commented Jan 16, 2025 •
edited
Loading

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (01/16/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (01/16/25)

1 label was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (01/16/25)

1 label was added to this PR based on Keith Williams's automation.

@dosubot dosubot bot added ui area: UI, frontend, button, form, input 🐛 bug Something isn't working labels Jan 16, 2025
Praashh
Praashh approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@Praashh Praashh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@github-actions GitHub Actions
Copy link
Contributor

E2E results are ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Praashh Praashh Praashh approved these changes

Assignees
No one assigned
Labels
🐛 bug Something isn't working community Created by Linear-GitHub Sync ready-for-e2e ui area: UI, frontend, button, form, input
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cnhhoang850 @Praashh