Add check for LP#2012284 #724
Conversation
| has_2012284: | ||
| input: | ||
| path: 'var/log/nova/nova-compute.log' | ||
| expr: ".+Failure prepping block device: gi.repository.GLib.GError: g-io-error-quark: Error opening directory '/usr/share/osinfo': Permission denied" |
There was a problem hiding this comment.
I think this should have a timestamp match, at least all the existing nova ones have something like this:
([\d-]+) ([\d:]+).\d{3} .+Failure...
There was a problem hiding this comment.
done. However, I had to change the quotation marks and the ' in the message to a . because they cannot be escaped in yaml (as far as I could find)
| type: LaunchpadBug | ||
| bug-id: 2012284 | ||
| message: >- | ||
| known nova compute issue caused when package gir1.2-libosinfo-1.0 is installed |
There was a problem hiding this comment.
Known (although most of the other scenario messages are lower case :-/ )
| bug-id: 2012284 | ||
| message: >- | ||
| known nova compute issue caused when package gir1.2-libosinfo-1.0 is installed | ||
| and apparmor is set to enforced. To fix the issue, the offending package needs to |
There was a problem hiding this comment.
I think it's actually "enforce" (without the d), at least according to the bug
| has_2012284: | ||
| input: | ||
| path: 'var/log/nova/nova-compute.log' | ||
| expr: '([\d-]+) ([\d:]+).\d{3} .+Failure prepping block device: gi.repository.GLib.GError: g-io-error-quark: Error opening directory ./usr/share/osinfo.: Permission denied' |
There was a problem hiding this comment.
So now I see I commented the opposite in your other patch - let's wait for Ed to confirm which is correct.
|
I would like the check to also check that the package is installed and/or enforce mode is set. If the issue gets fixed but the logs still exist we dont want to the issue to be raised. |
|
could also check whether or not nova-compute is in enforce or complain mode using #751 |
| raised-bugs: | ||
| https://bugs.launchpad.net/bugs/2012284: >- | ||
| Known nova compute issue caused when package gir1.2-libosinfo-1.0 is installed | ||
| and apparmor is set to enforce. To fix the issue, the offending package needs to |
There was a problem hiding this comment.
now that the apparmor helper is available you can actually check what mode nova-compute is in e.g.
vars:
nc_aa_mode: '@hotsos.core.host_helpers.apparmor.AAProfileFactory.mode:nova-compute'
checks:
nc_in_enforce_mode:
varops: [[$nc_aa_mode], [eq, enforce]]
...
``
| - sos_commands/date/date | ||
| raised-bugs: | ||
| https://bugs.launchpad.net/bugs/2012284: >- | ||
| Known nova compute issue caused when package gir1.2-libosinfo-1.0 is installed |
There was a problem hiding this comment.
If this package was to be uninstalled we would want to stop raising this issue if we saw the log message since that would be a false positive. Can we add a check that the package is installed?
rodrigogansobarbieri
force-pushed
the
check_lp2012284
branch
from
ba9836b to
9cb5b57
Compare
Error creating Nova VM with AppArmor set to "enforce": osinfo permission denied
rodrigogansobarbieri
force-pushed
the
check_lp2012284
branch
from
9cb5b57 to
1a99a65
Compare
rodrigogansobarbieri
force-pushed
the
check_lp2012284
branch
from
1a99a65 to
0c2ce9d
Compare
|
rebased and addressed review feedback |
|
lgtm thanks @rodrigogansobarbieri ! |
Error creating Nova VM with AppArmor set
to "enforce": osinfo permission denied
Closes: #723