-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow _daemon_ user to run sudo #46
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arturo-seijas
previously approved these changes
May 13, 2024
arturo-seijas
previously approved these changes
May 13, 2024
yanksyoon
previously approved these changes
May 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Could we include a small test to run sudo workflow?
Thanhphan1147
dismissed stale reviews from yanksyoon and arturo-seijas
via
May 13, 2024 12:51
d44be82
arturo-seijas
previously approved these changes
May 13, 2024
arturo-seijas
previously approved these changes
May 13, 2024
yanksyoon
previously approved these changes
May 13, 2024
Thanhphan1147
dismissed stale reviews from yanksyoon and arturo-seijas
via
May 14, 2024 15:08
67b0261
yanksyoon
previously approved these changes
May 14, 2024
Good idea! Will include that in. |
Added an integration test for the sudo! |
Test coverage for e5c90c4
Static code analysis report
|
yanksyoon
approved these changes
May 15, 2024
javierdelapuente
approved these changes
May 15, 2024
arturo-seijas
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the
_daemon_
user to run sudo without a password, used to allow agents to install packages depending on the use-case.Checklist
src-docs
urgent
,trivial
,complex
)