-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISD-2551 update README for jenkins-agent-k8s #52
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating this README!
Co-authored-by: Erin Conley <erin.conley@canonical.com>
Co-authored-by: Erin Conley <erin.conley@canonical.com>
Lint checks failed for 838d908
tests/integration/conftest.py:138: error: Item "Type" of "Type | None" has no attribute "units" [union-attr]
|
Test coverage for 838d908
Static code analysis report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more nitpick and then should be good to go!
[see the charm's detailed documentation](https://charmhub.io/jenkins-agent-k8s). | ||
* [Issues](https://github.com/canonical/jenkins-agent-k8s-operator/issues) <!--Link to GitHub issues (if applicable)--> | ||
* [Contributing](https://charmhub.io/jenkins-agent-k8s/docs/how-to-contribute) <!--Link to any contribution guides--> | ||
- [Matrix](https://matrix.to/#/#charmhub-charmdev:ubuntu.com) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- [Matrix](https://matrix.to/#/#charmhub-charmdev:ubuntu.com) | |
* [Matrix](https://matrix.to/#/#charmhub-charmdev:ubuntu.com) |
The rendering looks a little strange with the -
Update README to follow the template defined at : https://github.com/canonical/is-charms-template-repo
Checklist
src-docs
urgent
,trivial
,complex
)