chore: don't allow nil credential store #1514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we allow a nil credential store for legacy functionality to store secrets in Postgres or Vault. Nowadays secrets go to the CredentialStore interface which can be Vault/Postgres/Other. Secrets/sensitive data are now no longer in dbmodel types.
kian99
force-pushed
the
no-nil-credential-store
branch
2 times, most recently
from
4ef374a to
f59ab3a
Compare
kian99
force-pushed
the
no-nil-credential-store
branch
from
f59ab3a to
de3895e
Compare
alesstimec
approved these changes
Jan 10, 2025
| @@ -126,6 +126,9 @@ func (d *Database) Get(ctx context.Context, tag names.CloudCredentialTag) (_ map | |||
| secret := dbmodel.NewSecret(tag.Kind(), tag.String(), nil) | |||
| err = d.GetSecret(ctx, &secret) | |||
| if err != nil { | |||
| if errors.ErrorCode(err) == errors.CodeNotFound { | |||
| return nil, nil | |||
There was a problem hiding this comment.
why are we returning no error if it is not found?
There was a problem hiding this comment.
This is the behaviour of our Vault client, that test where I set it to run against Postgres and Vault showed that our Postgres implementation was not consistent with our Vault implementation. So I've changed the Postgres implementation to match Vault.
SimoneDutto
approved these changes
Jan 10, 2025
Yeah it will hopefully be better with the other managers because we can move whole files over and make changes rather than extracting bits and creating more lines changed than necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently we allow a nil credential store for legacy functionality to store secrets in Postgres or Vault. Nowadays secrets go to the CredentialStore interface which can use an underlying Vault/Postgres/Other. In addition, secrets/sensitive data are no longer in dbmodel types.
Fixes JUJU-7285
Engineering checklist