add config ssh jump server #1522
Conversation
| c.Assert(err, qt.IsNil) | ||
| hostKey := pem.EncodeToMemory( | ||
| &pem.Block{ | ||
| Type: "RSA PRIVATE KEY", |
There was a problem hiding this comment.
There's no constant for this?
There was a problem hiding this comment.
i've looked around and it's always a string, no types.
even in the godoc of this field:
Type string // The type, taken from the preamble (i.e. "RSA PRIVATE KEY").
cmd/jimmsrv/main.go
Outdated
| @@ -209,5 +209,18 @@ func start(ctx context.Context, s *service.Service) error { | |||
| }) | |||
| s.Go(httpsrv.ListenAndServe) | |||
| zapctx.Info(ctx, "Successfully started JIMM server") | |||
|
|
|||
| // // this is to show the integration, we will uncommented it once the ssh implementation is ready. | |||
There was a problem hiding this comment.
i would not add this in this PR as it might require a bit of discussion: do we start the jump server in main.go or in cmd/jimmsrv/service/service.go?
There was a problem hiding this comment.
yes, it was just to show how that would have worked, we can do it in another time.
yep, i will open a PR for the k8s charm as well |
SimoneDutto
force-pushed
the
JUJU-7350/add-config-ssh
branch
from
7e98e4f to
48be1cb
Compare
| type Config struct { | ||
| Port string | ||
| HostKey []byte | ||
| MaxConcurrentConnections string |
There was a problem hiding this comment.
why isn't the resolver field on the Config struct?
There was a problem hiding this comment.
the resolver is not a config but a service needed to operate the ssh server. I would leave it as a separate argument.
Don't you agree?
Description
In this PR we add configuration for SSH jump server.
Such as:
Engineering checklist
Test instructions