Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI to handle auto test and promote to strict and moonray branches #476

Merged
merged 15 commits into from
Jun 10, 2024

Conversation

neoaggelos
Copy link
Contributor

Summary

Adjust CI jobs for the informing strict integration tests and the auto-update jobs to handle the moonray patch as well.

@neoaggelos neoaggelos requested a review from a team as a code owner June 7, 2024 14:44
Copy link
Contributor

@eaudetcobello eaudetcobello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff. One comment.

Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comments

src/k8s/pkg/k8sd/features/calico/status.go Show resolved Hide resolved
src/k8s/pkg/k8sd/features/calico/status.go Show resolved Hide resolved
runs-on: ubuntu-20.04
strategy:
matrix:
patch: ["strict", "moonray"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add the patch matrix to our nightly run as well or add a follow-up card?

Copy link
Contributor

@louiseschmidtgen louiseschmidtgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @neoaggelos!
LGTM, let's make sure we have cards for the follow-up work.

@neoaggelos neoaggelos merged commit 6772673 into main Jun 10, 2024
17 checks passed
@neoaggelos neoaggelos deleted the KU-990/ci branch June 10, 2024 08:06
eaudetcobello pushed a commit that referenced this pull request Jun 17, 2024
…#476)

* Add CI to handle auto test and promote to strict and moonray branches

* also apply patch when running tests

* fix missing namespace issues with calico

* Disable more tests until features are implemented

* Add --timeout flags to status check commands

* do not fail fast on failing informing tests

* skip cleanup test (not yet implemented)

* relax default timeout

* refactor check network ready

* improve wording of x-wait-for failure commands

* retry on failures of checking DNS and network

* never return false without error

* disable test_network too

* avoid returning false, nil on CheckNetwork cilium

* fixup cilium messages
eaudetcobello pushed a commit that referenced this pull request Jun 17, 2024
…#476)

* Add CI to handle auto test and promote to strict and moonray branches

* also apply patch when running tests

* fix missing namespace issues with calico

* Disable more tests until features are implemented

* Add --timeout flags to status check commands

* do not fail fast on failing informing tests

* skip cleanup test (not yet implemented)

* relax default timeout

* refactor check network ready

* improve wording of x-wait-for failure commands

* retry on failures of checking DNS and network

* never return false without error

* disable test_network too

* avoid returning false, nil on CheckNetwork cilium

* fixup cilium messages
eaudetcobello pushed a commit that referenced this pull request Jun 17, 2024
…#476)

* Add CI to handle auto test and promote to strict and moonray branches

* also apply patch when running tests

* fix missing namespace issues with calico

* Disable more tests until features are implemented

* Add --timeout flags to status check commands

* do not fail fast on failing informing tests

* skip cleanup test (not yet implemented)

* relax default timeout

* refactor check network ready

* improve wording of x-wait-for failure commands

* retry on failures of checking DNS and network

* never return false without error

* disable test_network too

* avoid returning false, nil on CheckNetwork cilium

* fixup cilium messages
eaudetcobello pushed a commit that referenced this pull request Jun 17, 2024
…#476)

* Add CI to handle auto test and promote to strict and moonray branches

* also apply patch when running tests

* fix missing namespace issues with calico

* Disable more tests until features are implemented

* Add --timeout flags to status check commands

* do not fail fast on failing informing tests

* skip cleanup test (not yet implemented)

* relax default timeout

* refactor check network ready

* improve wording of x-wait-for failure commands

* retry on failures of checking DNS and network

* never return false without error

* disable test_network too

* avoid returning false, nil on CheckNetwork cilium

* fixup cilium messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants