-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI to handle auto test and promote to strict and moonray branches #476
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff. One comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, minor comments
runs-on: ubuntu-20.04 | ||
strategy: | ||
matrix: | ||
patch: ["strict", "moonray"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add the patch matrix to our nightly run as well or add a follow-up card?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @neoaggelos!
LGTM, let's make sure we have cards for the follow-up work.
…#476) * Add CI to handle auto test and promote to strict and moonray branches * also apply patch when running tests * fix missing namespace issues with calico * Disable more tests until features are implemented * Add --timeout flags to status check commands * do not fail fast on failing informing tests * skip cleanup test (not yet implemented) * relax default timeout * refactor check network ready * improve wording of x-wait-for failure commands * retry on failures of checking DNS and network * never return false without error * disable test_network too * avoid returning false, nil on CheckNetwork cilium * fixup cilium messages
…#476) * Add CI to handle auto test and promote to strict and moonray branches * also apply patch when running tests * fix missing namespace issues with calico * Disable more tests until features are implemented * Add --timeout flags to status check commands * do not fail fast on failing informing tests * skip cleanup test (not yet implemented) * relax default timeout * refactor check network ready * improve wording of x-wait-for failure commands * retry on failures of checking DNS and network * never return false without error * disable test_network too * avoid returning false, nil on CheckNetwork cilium * fixup cilium messages
…#476) * Add CI to handle auto test and promote to strict and moonray branches * also apply patch when running tests * fix missing namespace issues with calico * Disable more tests until features are implemented * Add --timeout flags to status check commands * do not fail fast on failing informing tests * skip cleanup test (not yet implemented) * relax default timeout * refactor check network ready * improve wording of x-wait-for failure commands * retry on failures of checking DNS and network * never return false without error * disable test_network too * avoid returning false, nil on CheckNetwork cilium * fixup cilium messages
…#476) * Add CI to handle auto test and promote to strict and moonray branches * also apply patch when running tests * fix missing namespace issues with calico * Disable more tests until features are implemented * Add --timeout flags to status check commands * do not fail fast on failing informing tests * skip cleanup test (not yet implemented) * relax default timeout * refactor check network ready * improve wording of x-wait-for failure commands * retry on failures of checking DNS and network * never return false without error * disable test_network too * avoid returning false, nil on CheckNetwork cilium * fixup cilium messages
Summary
Adjust CI jobs for the informing strict integration tests and the auto-update jobs to handle the moonray patch as well.