Fix nightly tests #876
Merged
Fix nightly tests #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The runner labels used by the nightly job are not correctly evaluated. We'll fix this by switching to the newly added one-string node labels.
petrutlucian94
force-pushed
the
lpetrut/fix-nightly
branch
from
d5eec84 to
3fd51bf
Compare
The containerd base dir setting is currently ignored when joining nodes. The reason is that yaml parser ignores a struct field which is marked as private. Making it public fixes the issue. At the same time, the test expects the default containerd folders to be missing when configured to use a different base dir. However, the tests are currently placing the registry settings in /etc/containerd. We also get an empty /run/containerd folder. For now, we'll update the test to ignore these folders. There's also an os.path.join call that doesn't produce the expected result if the last element is an absolute path, we'll need to remove a slash when constructing the paths.
petrutlucian94
force-pushed
the
lpetrut/fix-nightly
branch
from
51be17d to
72d17d3
Compare
louiseschmidtgen
changed the title
There was a problem hiding this comment.
Thanks for looking into the containerd issue @petrutlucian94!
Left some comments here:
| @@ -17,7 +17,7 @@ jobs: | |||
| release: ["latest/edge"] | |||
| fail-fast: false # TODO: remove once arm64 works | |||
|
|
|||
| runs-on: ${{ matrix.arch == 'arm64' && ["self-hosted", "Linux", "ARM64", "jammy", "large"] || ["self-hosted", "Linux", "AMD64", "jammy", "large"] }} | |||
| runs-on: ${{ matrix.arch == 'arm64' && 'self-hosted-linux-arm64-jammy-large' || 'self-hosted-linux-amd64-jammy-large' }} | |||
There was a problem hiding this comment.
Should we make this adjustment in our daily test as well?
There was a problem hiding this comment.
Not necessarily, we need it here because of the matrix.arch == 'arm64' && check, which doesn't work when followed by a list.
petrutlucian94
force-pushed
the
lpetrut/fix-nightly
branch
from
c385305 to
4a287d7
Compare
petrutlucian94
changed the title
We're adding a few checks to the integration tests workflow. We'll use the "weekly" tag in case of backports (targeting the release-* branches) and whenever there are test changes.
One of the tests uses a custom containerd base dir. We'll add a marker so that the registry mirror settings can be applied to that containerd folder.
petrutlucian94
force-pushed
the
lpetrut/fix-nightly
branch
from
4a287d7 to
79f14d4
Compare
petrutlucian94
force-pushed
the
lpetrut/fix-nightly
branch
from
79f14d4 to
c4140d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix nightly job
testsdir and in case of backports