Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tics: Fixes TICS nightly job #23

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

tics: Fixes TICS nightly job #23

wants to merge 1 commit into from

Conversation

claudiubelu
Copy link

@claudiubelu claudiubelu commented Jan 16, 2025

We don't have any unit tests for this project, but TICS expects the cover folder to exist.

TICS will try to use pylint and flake8 to analyze the project's code. We need to install them beforehand.

@claudiubelu claudiubelu requested a review from a team as a code owner January 16, 2025 13:34
@claudiubelu claudiubelu force-pushed the tics branch 4 times, most recently from 941ca02 to f18d09f Compare January 16, 2025 14:31
@claudiubelu claudiubelu marked this pull request as draft January 16, 2025 14:42
@claudiubelu claudiubelu force-pushed the tics branch 9 times, most recently from 538db4c to b11196b Compare January 17, 2025 12:42
We don't have any unit tests for this project, but TICS expects the
cover folder to exist.

TICS will try to use pylint and flake8 to analyze the project's code.
We need to install them beforehand.

Signed-off-by: Claudiu Belu <claudiu.belu@canonical.com>
@claudiubelu claudiubelu marked this pull request as ready for review January 17, 2025 12:50
@claudiubelu
Copy link
Author

Job passes: https://github.com/canonical/rawfile-localpv/actions/runs/12829129520/job/35774579666?pr=23

There is still an error there which is not a false positive:

2025-01-17T12:38:05.6571776Z [ERROR 5073] The following error(s) occurred while 'pylint' was running: 'E0401:5:0:Unable to import 'pytest'. Module 'pytest' not installed or specified on PYTHONPATH in the TICS configuration. The TICS PYTHONPATH is '/home/runner/work/rawfile-localpv/rawfile-localpv/'

That would require installing the tests/requirements-test.txt requirements as well, which will result in a conflict between pyyaml and PyYAML.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant