Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add reference docs for configuration options #113

Merged
merged 7 commits into from
Oct 25, 2023
Merged

add reference docs for configuration options #113

merged 7 commits into from
Oct 25, 2023

Conversation

tang-mm
Copy link
Contributor

@tang-mm tang-mm commented Oct 12, 2023 •
edited by jira bot
Loading

Add more reference docs from Goolge drive, including:

  • Device connector configuration options
  • Supported device connector types
  • Testfligner agent configuration options
  • Testfligner server configuration options (environment variables)

This PR resolves story: CERTTF-226 and CERTTF-225

@tang-mm tang-mm requested a review from a team October 12, 2023 06:33
@nancyc12 nancyc12 mentioned this pull request Oct 13, 2023
Closed
7 tasks
@tang-mm tang-mm force-pushed the doc-add-reference branch 2 times, most recently from ad8b0f7 to df025c9 Compare October 13, 2023 10:48
@tang-mm tang-mm force-pushed the doc-add-ref-config branch from e7aa4a0 to f60b643 Compare October 13, 2023 12:04
@tang-mm tang-mm changed the base branch from doc-add-reference to main October 13, 2023 12:04
plars
plars requested changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@plars plars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, a few small updates below

docs/reference/testflinger-agent-conf.rst Outdated Show resolved Hide resolved
docs/reference/device-connector-types.rst Outdated Show resolved Hide resolved
@tang-mm
Copy link
Contributor Author

tang-mm commented Oct 18, 2023

@plars I updated the command and config names per your comments. Could you review it again?
@nancyc12 I added the new firmware_update phase (#114 ) into the example. Could you take a look?

@tang-mm tang-mm requested review from plars and nancyc12 October 18, 2023 04:51
nancyc12
nancyc12 requested changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@nancyc12 nancyc12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tang-mm thanks for making the changes for the firmware_update_command. I added a suggestion for firmware_update_command example.

docs/reference/testflinger-agent-conf.rst Outdated Show resolved Hide resolved
@tang-mm @nancyc12
Doc: Update firmware_update_command example
1273ea4 
Co-authored-by: Nancy Chen <nancy.chen@canonical.com>
@tang-mm tang-mm requested a review from nancyc12 October 18, 2023 07:31
nancyc12
nancyc12 approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@nancyc12 nancyc12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@tang-mm tang-mm mentioned this pull request Oct 19, 2023
Merged
plars
plars approved these changes Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@plars plars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, didn't see the update here, +1 from me!

@plars
Copy link
Collaborator

plars commented Oct 24, 2023

resolved small merge conflict with the wordlist

@tang-mm tang-mm merged commit f04ab28 into main Oct 25, 2023
3 checks passed
@tang-mm tang-mm deleted the doc-add-ref-config branch October 25, 2023 03:21
@nancyc12 nancyc12 mentioned this pull request Oct 25, 2023
Merged
8 tasks
@tang-mm tang-mm mentioned this pull request Nov 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nancyc12 nancyc12 nancyc12 approved these changes

@plars plars plars approved these changes

Assignees
No one assigned
Labels
Libraries: Out of sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tang-mm @plars @nancyc12