update tf charm with prometheus scrap / metrics endpoint #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plars
requested changes
Oct 20, 2023
charm/config.yaml
Outdated
| @@ -7,3 +7,7 @@ options: | |||
| default: 10 | |||
| description: Number of seconds to wait for keepalive connections | |||
| type: int | |||
| api_port: | |||
There was a problem hiding this comment.
As in the previous PR, take this out - we don't need a config option for it because there's no reason for it to ever change.
charm/src/charm.py
Outdated
| self._prometheus_scraping = MetricsEndpointProvider( | ||
| self, | ||
| relation_name="metrics-endpoint", | ||
| jobs=[{"static_configs": [{"targets": [f"*:5000"]}]}], |
There was a problem hiding this comment.
I think this is what causes the lint failure. You have f"*:5000" but there's no placeholder for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Expose Prometheus metrics endpoint for COS lite
Resolved issues
https://warthogs.atlassian.net/browse/CERTTF-203