Post monorepo cleanup #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omar-selo
approved these changes
Oct 23, 2023
jocave
approved these changes
Oct 23, 2023
There was a problem hiding this comment.
These changes look good.
Other things that could or should be done:
- top-level readme giving just intro to project, point to read-the-docs for rest
- sub-project readmes could also just link to the info in read-the-docs if all info has been transferred
- possibly consolidate the .gitignores?
|
@jocave I added something for 1 and 3 - I think 2 should be coordinated more with the doc efforts right now? See what you think. |
jocave
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for small cleanups that we need after moving to the monorepo. Larger changes should go in a separate PR