Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge agent charms #139

Merged
merged 21 commits into from
Oct 23, 2023
Merged

Merge agent charms #139

merged 21 commits into from
Oct 23, 2023

Conversation

plars
Copy link
Collaborator

@plars plars commented Oct 23, 2023

This merges the existing testflinger agent charms from launchpad into the monorepo. I see this as a first step, and while they will work for now, they will still pull against the old github repos for now. I'll need to rework some things to make them properly work with the sources as we have them structured in the monorepo now. I'll do that in a separate PR later so that it doesn't have so much noise from merging all this git history from another repo and that will make it easier to review.

@plars plars requested a review from a team October 23, 2023 02:50
Copy link

@omar-selo omar-selo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that some checks failed. But my understanding is that this PR is just to move code here, and later PRs will fix things

@plars
Copy link
Collaborator Author

plars commented Oct 23, 2023

ok, fixed the complaints about the source layout without resorting to anything as invasive as I thought.

@plars plars merged commit 44bd09e into main Oct 23, 2023
2 checks passed
@plars plars deleted the merge-agent-charms branch October 23, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants