-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge agent charms #139
Merged
Merged
Merge agent charms #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ost-charm:support-focal-host
…harm:support-focal
…harm:fix-device-agent-config
…harm:github-branch-defaults
…harm:avoid-permission-problems-restart-file
…harm:add-update-action
omar-selo
approved these changes
Oct 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that some checks failed. But my understanding is that this PR is just to move code here, and later PRs will fix things
ok, fixed the complaints about the source layout without resorting to anything as invasive as I thought. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges the existing testflinger agent charms from launchpad into the monorepo. I see this as a first step, and while they will work for now, they will still pull against the old github repos for now. I'll need to rework some things to make them properly work with the sources as we have them structured in the monorepo now. I'll do that in a separate PR later so that it doesn't have so much noise from merging all this git history from another repo and that will make it easier to review.