Build cli snap workflow #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plars
force-pushed
the
build-cli-snap-workflow
branch
2 times, most recently
from
a7a5bac to
a3dafe1
Compare
mz2
reviewed
Oct 28, 2023
mz2
previously approved these changes
Oct 28, 2023
mz2
approved these changes
Nov 14, 2023
tang-mm
pushed a commit
that referenced
this pull request
Nov 27, 2023
* Add a github workflow to publish the cli snap * Update the README.rst with more information about snap publication * Also enable manual triggering of snap and server charm builds
nancyc12
pushed a commit
that referenced
this pull request
Dec 29, 2023
* Add a github workflow to publish the cli snap * Update the README.rst with more information about snap publication * Also enable manual triggering of snap and server charm builds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use a github workflow to build and publish the cli snap
Resolved issues
Previously, I did this through the snapcraft.io builders and set them up to watch the testflinger-cli repo and build automatically. However, those do not work with a monorepo because they don't support building the snap if it's in a directory. So we need to move this to use the gh workflow instead.
Documentation
N/A
Tests
I'm testing this by temporarily adding the proposed branch to the list of ones to trigger it
update: tested here: https://github.com/canonical/testflinger/actions/runs/6670022069/job/18129054928?pr=151
I also installed the resulting snap and tested it locally, works great :)