Update agent charms #155
Merged
Update agent charms #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@omar-selo or others... one other small change I just added was to explicitly skip removing the old "testflinger-agent" and "snappy-device-agents" dirs for now. We will add those back after all agents have been deployed with this version. The reason we need to do it in two steps, is because of the possibility that a job could be running when we update the agent. We want to give it an opportunity to finish running before we remove the old device agents, and I think this would be a safer way to do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the testflinger-agent-charm to use the monorepo
Resolved issues
There are some minor layout changes necessitated by moving to the monorepo. It is still the case that each agent gets installed under /srv/testflinger-agent/<agent_name>.
Previously, there was a
testflinger-agentandsnappy-device-agentsdirectory under there. Now that we have a monorepo, there will just be atestflingerdirectory there with a sparse/shallow checkout that only includes theagentanddevice-connectorsdirectories.Additionally, the config files have now moved to the root agent-dir, so that they are easier to find and manage.
Documentation
No real changes from a doc perspective. Installation and deployment are still the same.
Tests
To test this, I installed the old charm locally and pushed the new one to the edge channel, then refreshed the charm to use the edge one instead. The upgrades went perfectly and the new version of the agent was running after the upgrade.