Build the cli snap for all archs #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(We can continue to use snapcraft.io build infra, with lessons from the Checkbox project drawn on some do's and don'ts -- we can get back to this early next year if needed) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simon just pushed a change to update the base to core22 and I noticed after it landed that it only built for amd64. This is because we're in a monorepo now, so we couldn't continue using the snapcraft.io build infrastructure and had to switch to self-hosted runners - but they are only am64 right now. Fortunately, it's python and we don't really need to build on other archs. It should be sufficient to build once and run on all.
Resolved issues
Without this, we wouldn't have a snap for any other arch besides amd64. Which might not be an issue, or it might. At least it preserves that in case others are using it on other archs.
Documentation
no doc changes needed, snap install still works the same for it
Tests
Built locally