Ignore transmitting results if testflinger.json is missing #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Kevin pointed out a case today where the testflinger agent had died. There's a corner case where the results have already been transmitted so we remove testflinger.json to ensure it doesn't get transmitted again. But if the dir was unable to be removed, then it might still try again. If it fails to find testflinger.json then it can't get the job id and fails, but it should do so more gracefully in this case.
Tests
Added a unit test for this situation, and also added some other unit tests around this method that we were missing to increase coverage.