Temporarily disable output timeout checking until we have a better fix #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nadzyah
previously approved these changes
Mar 25, 2024
plars
force-pushed
the
disable-output-timeout-checking-for-now
branch
from
288ae6c to
ca3dff6
Compare
nadzyah
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This to work around an issue with how we do output timeout checking for now, until we have a better way.
When I originally refactored this, the output timeout checking was on another thread, but it was a bit hairy. That was one of the pieces I was trying to clean up, so I ended up consolidating it as a "stop_condition_checker" that we could register, but I missed the part where it needs to have awareness of the latest time new output was seen.
Will look into whether output timeout checking makes sense really, or at least providing a better fix.
But for now, it's very likely this could cause things to fail prematurely, so we need to address that immediately