Update server logic to select jobs with high priority #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plars
requested changes
Oct 11, 2024
val500
force-pushed
the
CERTTF-373
branch
3 times, most recently
from
5e1ebd9 to
4b0113f
Compare
plars
reviewed
Oct 22, 2024
plars
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This changes the query to get a job from the database to sort by job_priority first so jobs with highest priority get selected first. In addition, find_one_and_update was replaced by a find_one query and a separate update query. This is due to MongoDB not supporting the sort option for updates leading to a mismatch between the document that was found and the document that was updated.
Resolved issues
Resolves https://warthogs.atlassian.net/browse/CERTTF-373
Documentation
Web service API changes
N/A
Tests
Unit test was added to test_v1.py