-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add testflinger-testenv container #417
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plars
force-pushed
the
testflinger-testenv
branch
2 times, most recently
from
November 21, 2024 20:39
e57d60d
to
ef47185
Compare
plars
force-pushed
the
testflinger-testenv
branch
6 times, most recently
from
November 22, 2024 16:47
bd09241
to
8d2d3ce
Compare
plars
force-pushed
the
testflinger-testenv
branch
from
November 22, 2024 16:56
8d2d3ce
to
9165857
Compare
A few more changes:
|
nancyc12
previously approved these changes
Dec 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making this workflow! I only have a small question :)
plars
force-pushed
the
testflinger-testenv
branch
from
December 13, 2024 03:47
7f9e1b1
to
7c10bc2
Compare
nancyc12
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM+1
nancyc12
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When running the test phase for agents, we currently have it run under a docker image pulled from dockerhub at plars/testflinger-testenv-focal (don't be too bothered that it's focal based, it's just to give some working env on the agent-host and this one is well tested).
Now that we're on GH for everything, we should just use ghcr.io, so that nobody has to switch it over to a new location when that bus hits me some day :)
This is the first step in resolving this. I intentionally didn't change the path pointed to by the tf-test script that the agent calls yet, because we need to make sure firewall rules are all adjusted and everything before rolling this out in production.
Resolved issues
N/A
Documentation
There's a small README there just saying what it is, but this doesn't really do anything different, just moves the location
Web service API changes
N/A
Tests
Successful action run: https://github.com/canonical/testflinger/actions/runs/11961073449
Published container image: https://github.com/canonical/testflinger/pkgs/container/testflinger%2Ftestflinger-testenv
I also tried pulling this container image and running it locally.