Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad output with ssh keys in testflinger reserve command #425

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

plars
Copy link
Collaborator

@plars plars commented Dec 6, 2024

Description

testflinger reserve command could generate improperly formatted yaml
this fixes that and also adds a test for it

Resolved issues

CERTTF-461
#422

Documentation

N/A

Web service API changes

N/A

Tests

Added a new unit test

@plars plars requested a review from a team December 6, 2024 20:53
@jocave jocave linked an issue Dec 9, 2024 that may be closed by this pull request
jocave
jocave previously approved these changes Dec 9, 2024
Copy link
Collaborator

@jocave jocave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

omar-selo
omar-selo previously approved these changes Dec 9, 2024
Copy link

@omar-selo omar-selo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@plars plars dismissed stale reviews from omar-selo and jocave via 3163100 January 6, 2025 14:37
@plars plars force-pushed the fix-reserve-cmd-key-output branch from f522bfc to 3163100 Compare January 6, 2025 14:37
@plars plars requested review from jocave and omar-selo January 6, 2025 14:41
@plars
Copy link
Collaborator Author

plars commented Jan 6, 2025

Rebased to fix some conflicts

Copy link
Collaborator

@jocave jocave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@jocave jocave merged commit a9033cb into main Jan 6, 2025
2 checks passed
@jocave jocave deleted the fix-reserve-cmd-key-output branch January 6, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

testflinger-cli reserve with arguments generates invalid job yaml file
3 participants