Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor pyupdate improvements #440

Merged
merged 2 commits into from
Jan 10, 2025
Merged

minor pyupdate improvements #440

merged 2 commits into from
Jan 10, 2025

Conversation

plars
Copy link
Collaborator

@plars plars commented Jan 9, 2025

  • Use unittest.mock instead of mock and remove deprecated import
  • Use fstrings for server code

Description

Some minor cleanups which should definitely be safe. We technically still support python3.8 for the agent and device connectors, but I'm not sure we really need to since pretty much everything is on Jammy now, but I'll confirm with Taipei before going too far with that.

Resolved issues

N/A

Documentation

Web service API changes

N/A

Tests

Unit tests all still pass (and was even able to remove some deprecated imports during testing)

@plars plars requested a review from a team January 9, 2025 22:28
Copy link

@omar-selo omar-selo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@plars plars merged commit 01b1df2 into main Jan 10, 2025
3 checks passed
@plars plars deleted the minor-pyupdate-improvements branch January 10, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants