fix: cast for recursive queries on sqlite

[etimr]

To have the same behaviour on SQLite as on HANA, computed fields like DistanceFromRoot and LimitedDescendantCount should be returned as integers casted as strings, for example "1".

[patricebender]

if this change is for sqlite only, wouldn't it make sense to override the function in the sqlite/cql-functions.js? :)

If this is shared coding and it doesnt hurt for the other DBs, I'm fine with it!

[BobdenOs]

I don't think that this is SQLite specific as Postgres will also require it. Rather the code is currently only being tested with SQLite and HANA. The tests cannot be added here yet as it requires @sap/cds@9 to function.

[danjoa]

Also pls check this: If these fields are meant to be numbers they should always be returned as numbers, not always as strings, correct?

[etimr]

Also pls check this: If these fields are meant to be numbers they should always be returned as numbers, not always as strings, correct?

forgot to mention it in the description: we have strings only with the cds.env.features.ieee754compatible flag switched on, otherwise we are getting numbers.

[danjoa]

I'd like to have this discussed in a review.
Why are these number Int64?
Do we really expect hierarchy levels or ranks > 4294967295 ?
And: Do we really always have to add such query clumsinesses ?

[danjoa]

Why do we do that?

[etimr]

Bob is currently on vacation for the next two weeks, is it ok to have a review when he is back?

[johannes-vogel]

I'd like to have this discussed in a review. Why are these number Int64? Do we really expect hierarchy levels or ranks > 4294967295 ? And: Do we really always have to add such query clumsinesses ?

we currently always model it as int64 in our docs and samples. maybe also something to discuss tomorrow.