Skip to content

Fix Node.js event code argument type #1805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Node.js event code argument type #1805

wants to merge 1 commit into from

Conversation

swaldmann
Copy link
Contributor

For cap/issues/issues/18314.

@swaldmann swaldmann marked this pull request as ready for review April 30, 2025 12:11
@swaldmann swaldmann requested a review from smahati as a code owner April 30, 2025 12:11
@swaldmann swaldmann enabled auto-merge April 30, 2025 12:12
@swaldmann swaldmann requested a review from danjoa April 30, 2025 14:21
@swaldmann swaldmann disabled auto-merge April 30, 2025 14:23
danjoa
danjoa requested changes May 12, 2025
View reviewed changes
Copy link
Contributor

@danjoa danjoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We anyways need to thoroughly revise these docs, as we cleaned up respective implementations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danjoa danjoa danjoa requested changes

@smahati smahati Awaiting requested review from smahati smahati is a code owner

@johannes-vogel johannes-vogel Awaiting requested review from johannes-vogel

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swaldmann @danjoa