Skip to content

Review of migration guide #1841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Review of migration guide #1841

wants to merge 3 commits into from

Conversation

ecklie
Copy link
Contributor

@ecklie ecklie commented May 13, 2025

No description provided.

@ecklie ecklie requested a review from renejeglinsky as a code owner May 13, 2025 11:14
Copy link
Contributor

@renejeglinsky renejeglinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we have two warnings next to each other, a custom title would be beneficial. Here's a try.

@@ -21,7 +21,13 @@ Towards new multitenancy capabilities
<ImplVariantsHint />

::: warning
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
::: warning
::: warning Separate model changes from migration

@@ -21,7 +21,13 @@ Towards new multitenancy capabilities
<ImplVariantsHint />

::: warning
Make sure that you always use the latest version of the CAP modules using `npm outdated`. For Java, also check the versions configured in `pom.xml` files.
It is strongly recommended to separate any model changes from the migration. If you need to do model changes for the migration, please deploy the application
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
It is strongly recommended to separate any model changes from the migration. If you need to do model changes for the migration, please deploy the application
We strongly recommended to separate any model changes from the migration. If you need to do model changes for the migration, please deploy the application

It is strongly recommended to separate any model changes from the migration. If you need to do model changes for the migration, please deploy the application
based on `@sap/cds-mtx` and upgrade all tenants using the [upgrade endpoint](./old-mtx-apis.md#upgrade-base-model-from-filesystem-asynchronous) before you do the migration.
:::
::: warning
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
::: warning
::: warning Deprecated! Update all modules

:::
::: warning
Make sure that you always use the latest version of the CAP modules using `npm outdated`. For Java, also check the versions configured in `pom.xml` files. Since
`@sap/cds-mtx` is deprecated for quite some time now and will no longer run with e. g. the latest version of `@sap/cds`, updating the versions and adapting your application to it
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`@sap/cds-mtx` is deprecated for quite some time now and will no longer run with e. g. the latest version of `@sap/cds`, updating the versions and adapting your application to it
`@sap/cds-mtx` is deprecated for quite some time now and will no longer run with, for example, the latest version of `@sap/cds`, updating the versions and adapting your application to it

@@ -409,6 +415,13 @@ With `@sap/cds-mtxs`, the same configuration has moved to the `cds.xt.Extensibil
}
```

See also [Extensibility configuration](./mtxs.md#extensibility-config)

### Verify application locally
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Verify application locally
### Verify Application Locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants