clarify comp / assoc w.r.t. deep ops #881
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beckermarc
reviewed
May 2, 2024
| @@ -684,6 +684,7 @@ entity Orders.Items { | |||
|
|
|||
| :::info Contained-in relationship | |||
| Essentially, Compositions are the same as _[associations](#associations)_, just with the additional information that this association represents a _contained-in_ relationship so the same syntax and rules apply in their base form. | |||
| Deep operations permit modifications to the composition's target entity, unlike associations. | |||
There was a problem hiding this comment.
How does this relate to the docs here: https://pages.github.tools.sap/cap/docs/guides/domain-modeling#compositions?
Seems like this kind of information is already mentioned there. Maybe we should rather link this other section here and extend the other section with additional information that we feel is missing?
There was a problem hiding this comment.
@beckermarc , true, there seems to be some kind of overlap, but that also applies to all other features. I think I would leave it as is for now.
|
@David-Kunz @beckermarc @danjoa How to proceed here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's still missing / not clear:
Please let me know what you think!