Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wisdom from the old #27

Merged
merged 5 commits into from
Mar 18, 2024
Merged

Wisdom from the old #27

merged 5 commits into from
Mar 18, 2024

Conversation

SpheMakh
Copy link
Contributor

Add utils to convert old cabs to new cab. This is to make it easier to make stimela 2.0 cabs, but cabs converted this way should be manually checked and tested before being added to cult-cargo

@SpheMakh SpheMakh self-assigned this Mar 14, 2024
Copy link
Contributor

@Athanaseus Athanaseus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good.
Just a minor comment.

"""AI is creating summary for init_from_old_cab

Args:
oldcab (File): [description]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docstring Args don't match keyword args.

@o-smirnov
Copy link
Member

@SpheMakh, since there's a change to the casa6 image, did you run build-cargo casa6 to build and push the update?

@o-smirnov o-smirnov merged commit 7305ac6 into master Mar 18, 2024
4 checks passed
@o-smirnov o-smirnov mentioned this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants