Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

final pre-release PR. I hope. #34

Merged
merged 2 commits into from
Apr 3, 2024
Merged

final pre-release PR. I hope. #34

merged 2 commits into from
Apr 3, 2024

Conversation

o-smirnov
Copy link
Member

…y for release

@o-smirnov o-smirnov requested review from SpheMakh and Athanaseus April 2, 2024 19:47
Copy link
Contributor

@Athanaseus Athanaseus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good.
Just a minor comment

@@ -295,7 +295,7 @@ def resolve_config_reference(value):
if verbose:
print(f"Dockerfile:", style="bold")
print(f"{content}", style="dim", highlight=True)
run(f"docker build {no_cache} -t {full_image} -", cwd=build_dir, input=content)
run(f"docker build {no_cache} -t {full_image} -f- {build_dir}", cwd=build_dir, input=content)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
run(f"docker build {no_cache} -t {full_image} -f- {build_dir}", cwd=build_dir, input=content)
run(f"docker build {no_cache} -t {full_image} -f {build_dir}", cwd=build_dir, input=content)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No -f- is intentional, means read Dockerfile from stdin.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it

@Athanaseus
Copy link
Contributor

I also get the following:

$ build-cargo -b wsclean

────────────────────── Loading manifest /home/aramaila/.virtualenvs/stimela2/lib/python3.8/site-packages/cultcargo/builder/cargo-manifest.yml ───────────────────────
Package is cult-cargo==0.1.2
Checking github releases for caracal-pipeline/cult-cargo
  Available releases: 0.0.2 0.0.2.pl1 0.0.3 0.1.0 0.1.1 0.1.2rc1 0.1.2rc2 0.1.2rc3 0.1.2rc4 0.1.2rc5 0.1.2rc6 0.1.2rc7
  Working with an unreleased version, push allowed.
Registry is quay.io/stimela2, bundle is 'cc0.1.2', prefix 'cc'
Base image path is /home/aramaila/.virtualenvs/stimela2/lib/python3.8/site-packages/cultcargo/images
Loaded 18 image entries
───────────────────────────────────────────────────────────────────── Processing image wsclean ──────────────────────────────────────────────────────────────────────
wsclean:kern7-cc0.1.2 defined by /home/aramaila/.virtualenvs/stimela2/lib/python3.8/site-packages/cultcargo/images/wsclean/Dockerfile.kern7
Checking if registry already contains quay.io/stimela2/wsclean:kern7-cc0.1.2
  .$ docker manifest inspect quay.io/stimela2/wsclean:kern7-cc0.1.2
  Error inspecting manifest: open /etc/docker/certs.d/quay.io: permission denied

0:00:00 ⠇ image wsclean [0/1]: version kern7 [0/6]

@o-smirnov
Copy link
Member Author

Can you run docker manifest inspect quay.io/stimela2/wsclean:kern7-cc0.1.2 outside the script? It looks like there's something wrong with your quay.io login. `docker login quay.io`` maybe?

@Athanaseus
Copy link
Contributor

$ docker login quay.io

Authenticating with existing credentials...
WARNING! Your password will be stored unencrypted in /home/aramaila/.docker/config.json.
Configure a credential helper to remove this warning. See
https://docs.docker.com/engine/reference/commandline/login/#credentials-store

Login Succeeded

$ docker manifest inspect quay.io/stimela2/wsclean:kern7-cc0.1.2

open /etc/docker/certs.d/quay.io: permission denied

@o-smirnov
Copy link
Member Author

Weird.... which node is this on?

@Athanaseus
Copy link
Contributor

com-08

@o-smirnov
Copy link
Member Author

Same here. Try another box to be sure?

@o-smirnov
Copy link
Member Author

com08:/etc/docker was rwx------ for some reason. I fixed it now.

@o-smirnov o-smirnov merged commit 37e1965 into master Apr 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants