-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
final pre-release PR. I hope. #34
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good.
Just a minor comment
@@ -295,7 +295,7 @@ def resolve_config_reference(value): | |||
if verbose: | |||
print(f"Dockerfile:", style="bold") | |||
print(f"{content}", style="dim", highlight=True) | |||
run(f"docker build {no_cache} -t {full_image} -", cwd=build_dir, input=content) | |||
run(f"docker build {no_cache} -t {full_image} -f- {build_dir}", cwd=build_dir, input=content) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
run(f"docker build {no_cache} -t {full_image} -f- {build_dir}", cwd=build_dir, input=content) | |
run(f"docker build {no_cache} -t {full_image} -f {build_dir}", cwd=build_dir, input=content) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No -f-
is intentional, means read Dockerfile from stdin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it
I also get the following:
|
Can you run |
|
Weird.... which node is this on? |
|
Same here. Try another box to be sure? |
|
…y for release