Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental ddf kms support #36

Merged
merged 7 commits into from
Apr 18, 2024
Merged

Experimental ddf kms support #36

merged 7 commits into from
Apr 18, 2024

Conversation

o-smirnov
Copy link
Member

Adds images fo DDF/kMS. Note that there are no cabs for them yet, I'll defer this to a future release -- just wanted to add builder functionality for experimental branches for now.

@o-smirnov o-smirnov requested a review from SpheMakh April 18, 2024 08:37
Copy link
Contributor

@JSKenyon JSKenyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me though I don't know the intricacies of installing DDF and KMS. One missing newline at the end of a file and one spurious tab but that is largely cosmetic.

@o-smirnov o-smirnov merged commit dbb8600 into master Apr 18, 2024
3 checks passed
@o-smirnov o-smirnov deleted the ddf-kms branch April 18, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants