Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WSCLEAN temp-dir parameter updates #39

Merged
merged 3 commits into from
Apr 25, 2024
Merged

WSCLEAN temp-dir parameter updates #39

merged 3 commits into from
Apr 25, 2024

Conversation

JSKenyon
Copy link
Contributor

As reported by @landmanbester on the lightcurve pipeline repo, the current specification of the temp-dir parameter will not create one it if it does not exist. This PR addresses this issue by making the temp-dir an output. Outputs support mkdir. Additionally, this PR removes mkdir the non-output prefix parameter as it is not necessary.

@JSKenyon JSKenyon requested a review from o-smirnov April 25, 2024 12:02
Copy link
Member

@o-smirnov o-smirnov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

writable: true is not necessary for outputs. LGTM otherwise!

@o-smirnov o-smirnov merged commit c4a3f6b into master Apr 25, 2024
3 checks passed
@o-smirnov o-smirnov deleted the wsclean-temp-dir branch April 25, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants