Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change output image handling when no-dirty is specified. #40

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

JSKenyon
Copy link
Contributor

Currently, wsclean outputs presume the existence of dirty images. This may not be the case if the user has specified no-dirty in their config. This tiny fix should stop stimela from complaining about missing dirty images.

@JSKenyon JSKenyon requested review from o-smirnov and removed request for o-smirnov April 30, 2024 08:43
@JSKenyon
Copy link
Contributor Author

This isn't quite right yet - just need to fiddle the logic.

@JSKenyon JSKenyon requested a review from o-smirnov April 30, 2024 08:50
Copy link
Member

@o-smirnov o-smirnov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@o-smirnov o-smirnov merged commit 5c550b9 into master Apr 30, 2024
3 checks passed
@o-smirnov o-smirnov deleted the no-dirty-output branch April 30, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants