Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add wslean local-rms and move temp-dir to inputs #42

Merged
merged 3 commits into from
Jun 10, 2024
Merged

add wslean local-rms and move temp-dir to inputs #42

merged 3 commits into from
Jun 10, 2024

Conversation

SpheMakh
Copy link
Contributor

No description provided.

@SpheMakh SpheMakh requested a review from o-smirnov May 21, 2024 11:51
@SpheMakh SpheMakh requested review from JSKenyon and Athanaseus June 5, 2024 08:25
JSKenyon
JSKenyon reviewed Jun 6, 2024
View reviewed changes
Copy link
Contributor

@JSKenyon JSKenyon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me, but we probably need to discuss whether moving temp-dir to inputs is the correct choice. It is an input to wsclean, but it generates outputs from Stimela's perspective. See review comment for my reasoning.

@JSKenyon JSKenyon self-requested a review June 6, 2024 14:29
@o-smirnov o-smirnov merged commit 0f1837c into master Jun 10, 2024
3 checks passed
@o-smirnov o-smirnov deleted the local-rms branch June 10, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JSKenyon JSKenyon JSKenyon approved these changes

@o-smirnov o-smirnov Awaiting requested review from o-smirnov

@Athanaseus Athanaseus Awaiting requested review from Athanaseus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SpheMakh @JSKenyon @o-smirnov