Lower a single specific for a type. #5218
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently for functions only: A specific_id is created for each new type (use) found for a generic. If the function's LLVM types are the same with another previously found specific of the same generic, do not create a new LLVM function and use the previously created one.
zygoloid
reviewed
Mar 31, 2025
There was a problem hiding this comment.
I don't think it's sufficient to compare the function_type_info here. Two specifics for the same generic function might differ in ways that aren't part of the lowered function signature, for example because they use two different implementations of the same interface. See https://godbolt.org/z/vqcaKdb99 for instance.
I think we can do this if all the information that lowering gathers from the specific (all types and constant values that are used while lowering) are the same for multiple specifics of the same generic function, though.
This comment was marked as duplicate.
This comment was marked as duplicate.
|
Switched PR to draft, more details on resolution and path forward in the open discussion doc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently for functions only:
A specific_id is created for each new type (use) found for a generic. If the function's LLVM types are the same with another previously found specific of the same generic, do not create a new LLVM function and use the previously created one.