New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

203 fix error log tests #204

Merged

brendanheywood merged 2 commits into MOODLE_39_STABLE from 203-fix-error-log-tests

Nov 17, 2024

Contributor

matthewhilton commented Nov 17, 2024 •

edited

Loading

Closes #203

Changes

Made the error log ping not output during unit tests - we don't test for it outputting and it has the potential to pollute the test logs.
Made the pinging test deterministic by allowing you to pass in the time value, instead of relying on the test time.
Also fixed Ci errors - I think the CI must have updated recently causing new failures

Pull request checks

I have checked the version numbers are correct as per the README

matthewhilton added 2 commits

November 18, 2024 08:33


          [#203] Improve error log ping unit tests

373ffe5


          ci: cleanup to match coding standards

66b4c2c

brendanheywood approved these changes

View reviewed changes

brendanheywood merged commit da109a3 into MOODLE_39_STABLE

30 checks passed

brendanheywood deleted the 203-fix-error-log-tests branch

November 17, 2024 23:27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet