Adding more settings #652
Open
Adding more settings #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have been running this code on two Moodle instances connected via Minio and this plugin, and they work perfectly! |
|
Please do take a look at my repo of this, as it is also 33 commits behind and that could be why it's failing, but it is only very minor changes. To allow better functionality between this plugin and Minio. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I Mainly wanted to add more settings for the plugin to be more configurable, by adding the following
$config->s3_bucket_endpoint = 0;
$config->s3_use_path_style_endpoint = 0;
$config->s3_disable_multiregion_access_points = 0;